-
Notifications
You must be signed in to change notification settings - Fork 418
[0.0.124-bindings] Bindings-specific changes for 0.0.124 #3286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TheBlueMatt
merged 22 commits into
lightningdevkit:0.0.124-bindings
from
TheBlueMatt:2024-08-124-bindings
Sep 3, 2024
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
12411d1
Specify imports manually in `types::features::sealed`
TheBlueMatt 492b9c2
Make `as_directed_to` non-public
TheBlueMatt d5ef568
Restrict ChannelInfo::as_directed_from visibility
jkczyz 0f1e819
Use an explicit `Sign` type on the `ChannelMonitor` read tuple
TheBlueMatt 212e4a5
Export `outbound_payment` structs in their respective modules
TheBlueMatt 4ae9bcf
Avoid enums containing references with lifetimes
TheBlueMatt 0b978a1
Mark a few offers fields no-export as we have no mapping for them
TheBlueMatt ec446c9
Use `[u8; 3]` not `CurrencyCode` to skip type aliases to primitives
TheBlueMatt d8ec887
Hard-code scorer parameters to `ProbabilisticScoringFeeParameters`
TheBlueMatt f24cef0
Mark several types no-export which should be exported eventually
TheBlueMatt c029a65
`crate`-only several BOLT12 methods that require unbounded generics
TheBlueMatt 67fb2f4
Make ChannelMonitor always clonable
TheBlueMatt e9b7acb
Make the custom message traits cloneable as they're deep in nested st…
TheBlueMatt c6cfe88
Avoid slices without inner references
TheBlueMatt 6c8e19a
Avoid options holding references in the public API
TheBlueMatt 8f6819d
Hide `Direction::select_node_id` due to lifetimes
TheBlueMatt fa674ef
Drop `SerialId` type as bindings don't support primitive aliasing
TheBlueMatt 9301a0d
Minimal updates to `lightning-transaction-sync` for bindings
TheBlueMatt 3ffb48d
Require an OM in BP as this should generally be true and its easier t…
TheBlueMatt 020b479
Avoid returning references in `NodeAnnouncementInfo` accessors
TheBlueMatt 03d4eb5
Use `[u8; 32]` rather than `Hmac<Sha256>` for simplicity
TheBlueMatt 31b6b71
Use inline bounds for secp contexts, rather than `where` clauses
TheBlueMatt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
//! Common error types | ||
|
||
use std::fmt; | ||
|
||
#[derive(Debug)] | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like these files are missing the license
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, we should address that upstream.