Clarify Display text for ClosureReason::HolderForceClosed some
#3116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... to make it clear that we elected not to broadcast, rather than failed to broadcast.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3116 +/- ##
==========================================
- Coverage 89.82% 89.80% -0.02%
==========================================
Files 119 119
Lines 97991 97991
Branches 97991 97991
==========================================
- Hits 88016 88002 -14
- Misses 7400 7408 +8
- Partials 2575 2581 +6 ☔ View full report in Codecov by Sentry. |
tnull
approved these changes
Jun 12, 2024
|
Change is trivial, so not waiting for another reviewer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to make it clear that we elected not to broadcast, rather than failed to broadcast.
#3107 (comment)