Log available liquidity on each channel when starting routefinding #2931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't this more or less redundant since we already log rust-lightning/lightning/src/routing/router.rs Lines 2178 to 2183 in f5ee8c2 |
|
That won't tell us if the channel is disabled or otherwise missing, but, fair point, it does answer it in some cases. |
One of the most common first-steps in troubleshooting routefinding issues is we ask for the local channel state to determine what the available HTLC bounds are. While we log first-hop channel details when we decline to use them, this doesn't tell us if we have missing channels, and thus here we log all first-hop channels at the start. We also take this opportunity to log the limits that were violated any time we log that we're not using a channel, rather than only when its a first-hop.
TheBlueMatt
force-pushed
the
2024-03-log-outbound-channels
branch
from
44c08df to
136e89e
Compare
|
Rebased and updated a bit, I think this this is worth doing, and also took the opportunity to log the limit that is violated any time we log that we're not using a channel, rather than only when its a first-hop. |
valentinewallace
approved these changes
May 30, 2024
tnull
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the most common first-steps in troubleshooting routefinding issues is we ask for the local channel state to determine what the available HTLC bounds are. Thus, we really should be logging the bounds instead, which we do here.