Drop panic if rust-bitcoin adds a new Network #2746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`rust-bitcoin` 0.30 added `#[non_exhaustive]` to the `Network` enum, allowing them to "add support" for a new network type without a major version change in the future. When upgrading, we added a simple `unreachable` for the general match arm, which would break in a minor version change of `rust-bitcoin`. While it seems [possible rust-bitcoin will change this](rust-bitcoin/rust-bitcoin#2225), we still shouldn't ba panicking, which we drop here in favor of a `debug_assert`ion, and a default value.
Now that we use the `rust-bitcoin` `WitnessProgram` to check our addresses, we can just rely on it, rather than checking the program length and version.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2746 +/- ##
==========================================
- Coverage 88.55% 88.54% -0.01%
==========================================
Files 113 113
Lines 89323 89316 -7
Branches 89323 89316 -7
==========================================
- Hits 79097 79086 -11
- Misses 7860 7862 +2
- Partials 2366 2368 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-bitcoin0.30 added#[non_exhaustive]to theNetworkenum, allowing them to "add support" for a new network type without
a major version change in the future. When upgrading, we added a
simple
unreachablefor the general match arm, which would breakin a minor version change of
rust-bitcoin.While it seems possible rust-bitcoin will change
this,
we still shouldn't ba panicking, which we drop here in favor of a
debug_assertion, and a default value.Plus one extra change.