-
Notifications
You must be signed in to change notification settings - Fork 404
Cut 0.0.117 #2620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cut 0.0.117 #2620
Conversation
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2620 +/- ##
==========================================
- Coverage 89.09% 89.06% -0.03%
==========================================
Files 112 112
Lines 86959 86959
Branches 86959 86959
==========================================
- Hits 77475 77449 -26
- Misses 7258 7276 +18
- Partials 2226 2234 +8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
total, these changes should result in improved payment success rates at the | ||
cost of slightly worse routefinding performance. | ||
* Support for custom TLVs for recipients of HTLCs has been added (#2308). | ||
* Support for generating transactions for third-party watchtowers has been |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be noted justice transactions claiming only the revoked to_local
, not potential revoked HTLC output or second-stage HTLC outputs, iirc #2337 changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's how ~all watchtowers work today.
89e1d91
to
147d736
Compare
Squashed the fixups and rebased 🎉 |
147d736
to
c748746
Compare
Few minor spelling nits: $ git diff-tree -U1 147d736e c7487460
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 9bff8a18c..a050afb72 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -63,5 +63,5 @@
## Backwards Compatibility
- * User migrating from `KVStorePersister` can use a concatentation of
- `[{primary_namespace}/[{secondary_namespace}/]]{key}` to build a compatible
- data when using the new `KVStore` persistence interface (#2472).
+ * Users migrating to the new `KVStore` can use a concatentation of
+ `[{primary_namespace}/[{secondary_namespace}/]]{key}` to build a key
+ compatible with the previous `KVStorePersister` interface (#2472).
* Downgrading after receipt of a payment with custom HTLC TLVs may result in
@@ -76,3 +76,3 @@
* First, make a backup copy of all channel state,
- * Then ensure all `ChannelMonitorUpdate`s stored are fully applied to the
+ * then ensure all `ChannelMonitorUpdate`s stored are fully applied to the
relevant `ChannelMonitor`,
@@ -83,3 +83,3 @@
commitment transaction (i.e. force-closing) would previously not generate a
- `SpendableOutputs` event for the `to_local` (i.e. non-HTLC-encumbered)
+ `SpendableOutputs` event for our `to_remote` (i.e. non-HTLC-encumbered)
balance. Those with such balances available should fetch the missing
$ |
No description provided.