Avoid early return upon confirmation of channel funding #2622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2622 +/- ##
==========================================
- Coverage 89.03% 88.99% -0.05%
==========================================
Files 112 112
Lines 86351 86405 +54
Branches 86351 86405 +54
==========================================
+ Hits 76879 76892 +13
- Misses 7235 7274 +39
- Partials 2237 2239 +2
☔ View full report in Codecov by Sentry. |
valentinewallace
approved these changes
Sep 29, 2023
This early return is only possible if the channel requires a single confirmation, allowing a `channel_ready` message to go out. This can be problematic though if a commitment transaction (specifically from the counterparty, as the channel would be immediately closed if a local commitment is broadcast) also confirms within the same block. The `ChannelMonitor` will detect both, but it won't inform the `ChannelManager` at all. Luckily, while the channel still is considered open to the `ChannelManager`, the `ChannelMonitor` will reject any further updates to the channel state.
wpaulino
force-pushed
the
funding-and-commitment-tx-confirm-same-block
branch
from
35b02cb to
92fcdd3
Compare
jkczyz
approved these changes
Sep 29, 2023
TheBlueMatt
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This early return is only possible if the channel requires a single confirmation, allowing a channel_ready message to go out. This can be problematic though if a commitment transaction (specifically from the counterparty, as the channel would be immediately closed if a local commitment is broadcast) also confirms within the same block. The
ChannelMonitor will detect both, but it won't inform the ChannelManager at all. Luckily, while the channel still is considered open to the ChannelManager, the ChannelMonitor will reject any further updates to the channel state.