Correct syn pinning on cargo 1.48 #2584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
force-pushed
the
2023-09-msrv-try-2
branch
from
ab60bcc to
f1ac34f
Compare
Sadly the pinning introduced in 050f5a9 was brittle in the face of any further syn updates, and has already broken. Here we fix it by looking up the actual version of syn to pin. Note that this dependency is somewhat nonsense as its actually only a `criterion` dependency, pulled in even though we haven't set the bench flag (as we aren't yet using `resolver = 2`).
TheBlueMatt
force-pushed
the
2023-09-msrv-try-2
branch
5 times, most recently
from
d8a8390 to
87b149b
Compare
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2584 +/- ##
==========================================
- Coverage 90.63% 88.88% -1.75%
==========================================
Files 113 113
Lines 59054 84242 +25188
Branches 59054 84242 +25188
==========================================
+ Hits 53522 74880 +21358
- Misses 5532 7137 +1605
- Partials 0 2225 +2225
☔ View full report in Codecov by Sentry. |
We're not actually using the build output, so there's no reason to do a build vs just running check.
TheBlueMatt
force-pushed
the
2023-09-msrv-try-2
branch
from
87b149b to
e1707ba
Compare
valentinewallace
approved these changes
Sep 18, 2023
wpaulino
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sadly the pinning introduced in 050f5a9 was brittle in the face of any further syn updates, and has already broken.
Here we fix it by looking up the actual version of syn to pin.
Note that this dependency is somewhat nonsense as its actually only a
criteriondependency, pulled in even though we haven't set the bench flag (as we aren't yet usingresolver = 2).