Skip to content

Fail channel when BADONION is not set #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2018

Conversation

yuntai
Copy link
Contributor

@yuntai yuntai commented Nov 5, 2018

when update_fail_malformed_htlc is received.

if the BADONION bit in failure_code is not set for update_fail_malformed_htlc:
MUST fail the channel.

found while testing for onion_error handling (#146, which is close to being finished!)

There is another condition in the spec

if the sha256_of_onion in update_fail_malformed_htlc doesn't match the onion it sent:
MAY retry or choose an alternate error response.
, which is not clear as to what 'alternate error response' should be used. And `retry' for random bit error?

@TheBlueMatt TheBlueMatt merged commit 74f59a2 into lightningdevkit:master Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants