Make lightning::sync public #2376
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe it might have always been the intention. I tested this 116-alpha1 fork out on Mutiny and sending / receiving seems to be working, just needed pub here.
Needed so that I could use some of the no_std mutex stuff in the
syncpackage. Judging by all thepubstructs and functions insync, maybe it was just an oversight that it wasn't public before? If it needs to be private, I may need some help figuring out how to work around it.Also, I think a handful of things need docs. I really don't know what to say about them. Happy to put whatever you guys recommend or let maintainers edit this PR directly.