Skip to content

Conversation

@TheBlueMatt
Copy link
Collaborator

No description provided.

@TheBlueMatt TheBlueMatt added this to the 0.0.116alpha milestone Jun 23, 2023
Copy link
Contributor

@jkczyz jkczyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the caveat that I didn't realize version numbers like this were allowed.

@TheBlueMatt
Copy link
Collaborator Author

We did 0.0.114-beta, so I assume -alpha1 is okay :)

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (3973865) 90.30% compared to head (23e9fc7) 90.32%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2373      +/-   ##
==========================================
+ Coverage   90.30%   90.32%   +0.02%     
==========================================
  Files         106      106              
  Lines       54900    54900              
  Branches    54900    54900              
==========================================
+ Hits        49576    49589      +13     
+ Misses       5324     5311      -13     

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TheBlueMatt TheBlueMatt merged commit 3a98c2a into lightningdevkit:main Jun 23, 2023
@TheBlueMatt TheBlueMatt modified the milestones: 0.0.116alpha, 0.0.116 Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants