Ensure we build if a downstream crate sets --cfg=fuzzing
#2365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CI is not happy. |
TheBlueMatt
force-pushed
the
2023-06-fix-fuzz-dep
branch
from
47a657a to
87c5b48
Compare
Collaborator
Author
|
Well I'm not happy with CI. Took a totally different approach tho. |
TheBlueMatt
force-pushed
the
2023-06-fix-fuzz-dep
branch
2 times, most recently
from
ab5c94a to
57bd6f7
Compare
Downstream crates building fur fuzzing will usually set `--cfg=fuzzing` as a side-effect of the Rust fuzzing tooling. Thus, we should ensure we build without failure in such cases. We do this here by simply relying on the `_test_utils` feature, rather than conditionally-compiling in modules based on the `fuzzing` flag.
TheBlueMatt
force-pushed
the
2023-06-fix-fuzz-dep
branch
from
57bd6f7 to
e49a1ba
Compare
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #2365 +/- ##
==========================================
- Coverage 90.32% 90.31% -0.02%
==========================================
Files 106 106
Lines 54591 54591
Branches 54591 54591
==========================================
- Hits 49311 49303 -8
- Misses 5280 5288 +8
☔ View full report in Codecov by Sentry. |
wpaulino
approved these changes
Jun 21, 2023
valentinewallace
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream crates building fur fuzzing will usually set
--cfg=fuzzingas a side-effect of the Rust fuzzing tooling. Thus, we should ensure we build without failure in such cases.