Introduce a ChannelType enum in lieu of opt_anchors
#2321
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54 tasks
arik-so
force-pushed
the
2023-05-channel-type-enum
branch
from
36c2d54 to
2824fe1
Compare
|
Requesting concept ACK @TheBlueMatt? |
|
Sorry for the delay. Does it make sense to use the ChannelTypeFeatures instead? Note that since anchors still isn't enabled outside of a cfg I think we can mostly still break the serialization of it just fine. |
|
Would that be more human-legibility- and maintainability-friendly than the enum? I'm fine using ChannelTypeFeatures. |
|
I think so, its more straightforward in the sense that its an existing type that captures what we need and will be trivially future-extensible. |
|
Superseded by #2361. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.