Migrate ChannelMonitor writing/reading to new serialization framework #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sadly we can't straight up use the new serialization framework as we have a few different serialization variants, but that's OK, it looks identical and is just missing the Writeable impl
TheBlueMatt
force-pushed
the
2018-09-chanmon-ser-framework
branch
from
12b1087 to
79a0a0c
Compare
|
After going back to and having finished #157, I will tackle this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, I really half-assed this one. I wanted to get the API changes out of the way, but internally the functions still do all their own logic, which is dumb, especially considering the serialization framework has a bunch of logic prepped for ChannelMonitors already. Anyway, I assume @yuntai will want to take this over from here and I'll leave it at that.