Require directional updates for a DirectionalChannelInfo #1815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 90.72% // Head: 90.74% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1815 +/- ##
==========================================
+ Coverage 90.72% 90.74% +0.02%
==========================================
Files 87 87
Lines 47361 47336 -25
Branches 47361 47336 -25
==========================================
- Hits 42968 42957 -11
+ Misses 4393 4379 -14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
TheBlueMatt
changed the title
We currently construct `DirectedChannelInfo`s for routing before checking if the given direction has its directional info filled in. We then always check for directional info before actually deciding to route over a channel, as otherwise we assume the channel is not online. This makes for somewhat redundant checks, and `DirectedCHannelInfo` isn't, by itself, a very useful API. Because fetching the HTLC-max or effective channel capacity gives spurious data if no directional info is available, there's little reason to have that data available, and so we here check for directional info first. This effectively merges `DirectionalChannelInfo` and `DirectionalChannelInfoWithUpdate`.
Because we now never generate an `EffectiveCapacity` with an `htlc_maximum_msat` set to `None`, making it non-`Option`al effectively removes dead code, which we do here.
TheBlueMatt
force-pushed
the
2022-10-dead-gossip-code
branch
from
064bfe2 to
4df0ff7
Compare
valentinewallace
approved these changes
Oct 31, 2022
wpaulino
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently construct
DirectedChannelInfos for routing beforechecking if the given direction has its directional info filled in.
We then always check for directional info before actually deciding
to route over a channel, as otherwise we assume the channel is not
online.
This makes for somewhat redundant checks, and
DirectedCHannelInfoisn't, by itself, a very useful API. Because fetching the HTLC-max
or effective channel capacity gives spurious data if no directional
info is available, there's little reason to have that data
available, and so we here check for directional info first. This
effectively merges
DirectionalChannelInfoandDirectionalChannelInfoWithUpdate.