Fix encoding/decoding for OpenChannel #166
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR lightningdevkit#119 fails on no_existing_test_breakage() which uses hex from this buggy encoding. Perhaps use this to regenerate hex?
|
ah, it's encrypted. can't really edit hex |
|
It looked right to me to begin with. I don't think you write a 0 if the scriptpubkey is missing - its determined by a feature bit, so its just missing. |
|
ah.. don't know what I was thinking. clearly (option_upfront_shutdown_script) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #119 fails on
no_existing_test_breakage()which uses hex from this buggyencoding.
This PR fails at the same spot. Not sure I should edit hex or it's better to regenerate hex with this fix.