Skip to content

Fix encoding/decoding for OpenChannel #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

yuntai
Copy link
Contributor

@yuntai yuntai commented Sep 10, 2018

PR #119 fails on no_existing_test_breakage() which uses hex from this buggy
encoding.

This PR fails at the same spot. Not sure I should edit hex or it's better to regenerate hex with this fix.

PR lightningdevkit#119 fails on no_existing_test_breakage() which uses hex from this buggy
encoding. Perhaps use this to regenerate hex?
@yuntai
Copy link
Contributor Author

yuntai commented Sep 10, 2018

ah, it's encrypted. can't really edit hex

@TheBlueMatt
Copy link
Collaborator

It looked right to me to begin with. I don't think you write a 0 if the scriptpubkey is missing - its determined by a feature bit, so its just missing.

@yuntai
Copy link
Contributor Author

yuntai commented Sep 10, 2018

ah.. don't know what I was thinking. clearly (option_upfront_shutdown_script)
closing.

@yuntai yuntai closed this Sep 10, 2018
@yuntai yuntai deleted the fix-open-channel-encodable branch September 11, 2018 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants