-
Notifications
You must be signed in to change notification settings - Fork 407
Add convenient GossipSync variant constructors #1618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TheBlueMatt
merged 1 commit into
lightningdevkit:main
from
wpaulino:gossip-sync-constructors
Jul 15, 2022
Merged
Add convenient GossipSync variant constructors #1618
TheBlueMatt
merged 1 commit into
lightningdevkit:main
from
wpaulino:gossip-sync-constructors
Jul 15, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1618 +/- ##
==========================================
- Coverage 91.07% 90.81% -0.26%
==========================================
Files 80 80
Lines 44128 44645 +517
Branches 44128 44645 +517
==========================================
+ Hits 40190 40546 +356
- Misses 3938 4099 +161
Continue to review full report at Codecov.
|
jkczyz
reviewed
Jul 14, 2022
jkczyz
previously approved these changes
Jul 15, 2022
TheBlueMatt
reviewed
Jul 15, 2022
f3cb61f
to
bc08c22
Compare
jkczyz
previously approved these changes
Jul 15, 2022
These constructors fill in the missing types for each variant so that users don't have to turbofish them manually.
bc08c22
to
6877539
Compare
jkczyz
approved these changes
Jul 15, 2022
TheBlueMatt
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These constructors fill in the missing types for each variant so that users don't have to turbofish them manually.
I verified that we could use all of these within
ldk-sample
without needing to turbofish.Fixes #1594.