Use a separate (non-trait) fee-estimation fn in LowerBoundedEstimator #1611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1611 +/- ##
==========================================
- Coverage 90.87% 90.77% -0.10%
==========================================
Files 80 80
Lines 44569 44651 +82
Branches 44569 44651 +82
==========================================
+ Hits 40500 40530 +30
- Misses 4069 4121 +52
Continue to review full report at Codecov.
|
wpaulino
previously approved these changes
Jul 13, 2022
dunxen
previously approved these changes
Jul 15, 2022
|
Pushed an extra commit that is gonna be required for the bindings, but is rather simple. |
|
The one fuzz just needs the reference to the estimator changed, otherwise looks good. |
TheBlueMatt
force-pushed
the
2022-07-lower-bounded-estimator-nit
branch
from
9d08b60 to
5f28d17
Compare
|
Oops, indeed, thanks. |
dunxen
previously approved these changes
Jul 22, 2022
tnull
reviewed
Jul 25, 2022
TheBlueMatt
force-pushed
the
2022-07-lower-bounded-estimator-nit
branch
from
1b5bee6 to
3c5d7da
Compare
|
LGTM, feel free to squash. |
This should make it somewhat more difficult to accidentally use a straight fee estimator when we actually want a LowerBoundedFeeEstimator by not having the types be exchangeable at all.
This simplifies things for bindings (and, to some extent, downstream users) by exploiting the fact that we can always "clone" a reference to a struct by dereferencing and then creating a new reference.
This change the method name on `LowerBoundedFeeEstimator` to further differentiate it from the generic `FeeEstimator` trait.
TheBlueMatt
force-pushed
the
2022-07-lower-bounded-estimator-nit
branch
from
3c5d7da to
af7e9b6
Compare
|
Rebased without further changes. |
wpaulino
approved these changes
Jul 25, 2022
valentinewallace
approved these changes
Jul 25, 2022
tnull
approved these changes
Jul 25, 2022
dunxen
approved these changes
Jul 25, 2022
|
Go home Github, you're drunk (the missing required job did run, and passed...but is still listed as pending run...). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it somewhat more difficult to accidentally use a
straight fee estimator when we actually want a
LowerBoundedFeeEstimator by not having the types be exchangeable at
all.