Fix lightning-background-processor release build

[MaxFangX]

Problem

cargo build --release

error[E0425]: cannot find value `SCORER_PERSIST_TIMER` in this scope
   --> lightning-background-processor/src/lib.rs:360:55
    |
360 |                 if last_scorer_persist_call.elapsed().as_secs() > SCORER_PERSIST_TIMER {
    |                                                                   ^^^^^^^^^^^^^^^^^^^^ not found in this scope

warning: ignoring -C extra-filename flag due to -o flag

For more information about this error, try `rustc --explain E0425`.
warning: `lightning-background-processor` (lib) generated 1 warning
error: could not compile `lightning-background-processor` due to previous error; 1 warning emitted

Solution

Remove the debug_assertions compilation condition so that SCORER_PERSIST_TIMER will be compiled when building for release.

[codecov-commenter]

Codecov Report

Merging #1533 (e291fb6) into main (22dc964) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1533      +/-   ##
==========================================
- Coverage   90.94%   90.91%   -0.03%     
==========================================
  Files          80       80              
  Lines       43469    43469              
  Branches    43469    43469              
==========================================
- Hits        39533    39521      -12     
- Misses       3936     3948      +12     

Impacted Files	Coverage Δ
lightning-background-processor/src/lib.rs	95.20% <ø> (ø)
lightning/src/ln/functional_tests.rs	96.98% <0.00%> (-0.18%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22dc964...e291fb6. Read the comment docs.

[tnull]

Ah, good catch!

LGTM.

[TheBlueMatt]

Ouch. This needs CI so that this doesn't regress.

[tnull]

Ouch. This needs CI so that this doesn't regress.

Agreed, will open a PR that adds a job with cargo check --release.

[arik-so]

Post-merge ACK