Scale up CLTV_FAR_FAR_AWAY to 2 weeks of blocks #1532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
previously approved these changes
Jun 9, 2022
Codecov Report
@@ Coverage Diff @@
## main #1532 +/- ##
==========================================
- Coverage 90.94% 90.91% -0.03%
==========================================
Files 80 80
Lines 43469 43469
Branches 43469 43469
==========================================
- Hits 39533 39521 -12
- Misses 3936 3948 +12
Continue to review full report at Codecov.
|
wpaulino
previously approved these changes
Jun 9, 2022
|
Lets hold off merging until 109 for this. |
kaiwolfram
reviewed
Jun 16, 2022
lightning/src/ln/channelmanager.rs
Outdated
| // in case of HTLC on-chain settlement. While appearing less competitive, a node operator could decide to | ||
| // scale them up to suit its security policy. At the network-level, we shouldn't constrain them too much, | ||
| // while avoiding to introduce a DoS vector. Further, a low CTLV_FAR_FAR_AWAY could be a source of | ||
| // routing failure for any HTLC sender picking up a LDK node among the first hops. |
There was a problem hiding this comment.
Suggested change
| // routing failure for any HTLC sender picking up a LDK node among the first hops. | |
| // routing failure for any HTLC sender picking up an LDK node among the first hops. |
TheBlueMatt
approved these changes
Jun 16, 2022
wpaulino
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be long enough to allow a payment path drawn across multiple routing hops with substantial
cltv_expiry_delta. Indeed, the length of those values is the reaction delay offered to a routing nodein case of HTLC on-chain settlement. While appearing less competitive, a node operator could decide to
scale them up to suit its security policy. At the network-level, we shouldn't constrain them too much,
while avoiding to introduce a DoS vector. Further, a low CTLV_FAR_FAR_AWAY could be a source of
routing failure for any HTLC sender picking up a LDK node among the first hops.
Also default value of both LND and CLN.