Ensure handle_announcement_signatures always has a ErrorAction #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ariard
reviewed
Sep 1, 2018
| let onion_keys = ChannelManager::construct_onion_keys(&self.secp_ctx, &route, &session_priv)?; | ||
| //TODO: This should return something other than HandleError, that's really intended for | ||
| //p2p-returns only. | ||
| let onion_keys = secp_call!(ChannelManager::construct_onion_keys(&self.secp_ctx, &route, &session_priv), "Pubkey along hop was maliciously selected", msgs::ErrorAction::IgnoreError); |
There was a problem hiding this comment.
Why not extend HandleError further than p2p-returns, something like MarkNodeAsBad { node_id }, could be useful to nodes ban ?
There was a problem hiding this comment.
Maybe, but best to have more Err types so that you don't end up having match arms that don't make sense in context. eg having a user call send_payment then matching the Err type and ending up with a SendErrMessage action (but they don't know where to send it) is nonsense. Maybe if the full set always makes sense in context but I'm skeptical that'll work out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This + #134 should resolve #129 for BOLT 4, though it'll need another read-through pass. (+ a bonus)