Handle Payment Metadata in the Invoice/Send/Receive Pipelines #1221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
force-pushed
the
2021-12-payment-metadata
branch
from
12d90c2 to
49055f8
Compare
Closed
TheBlueMatt
force-pushed
the
2021-12-payment-metadata
branch
from
49055f8 to
01f20d7
Compare
TheBlueMatt
force-pushed
the
2021-12-payment-metadata
branch
from
01f20d7 to
6d898f6
Compare
|
Rebased. |
There is no reason to set both, and this currently makes testing the new BOLT invoice tests slightly harder, so we just unset it.
...instead of accessing it via the `OnionPayload::Invoice` form. This may be useful if we add MPP keysend support, but is directly useful to allow us to drop `FinalOnionHopData` from `OnionPayload`.
We only use it to check the amount when processing MPP parts, but store the full object (including new payment metadata) in it. Because we now store the amount in the parent structure, there is no need for it at all in the `OnionPayload`. Sadly, for serialization compatibility, we need it to continue to exist, at least temporarily, but we can avoid populating the new fields in that case.
...without exposing it to the public `send_payment` API yet.
TheBlueMatt
force-pushed
the
2021-12-payment-metadata
branch
from
6d898f6 to
cd7e5ac
Compare
|
Oops, actually rebased now. |
Closed
andozw
added a commit
to andozw/rust-lightning
that referenced
this pull request
Apr 22, 2022
This work is a pre-req for [Issue-1298](lightningdevkit#1298). This is a rebase of [PR-1221](lightningdevkit#1221) with an additional commit to move the payment_secret and the payment_metadata into a new struct called RecipientInfo. This will allow us to add custom onion TLVs (see [discussion](lightningdevkit#1298 (comment)))
andozw
added a commit
to andozw/rust-lightning
that referenced
this pull request
Apr 22, 2022
This work is a pre-req for [Issue-1298](lightningdevkit#1298). This is a rebase of [PR-1221](lightningdevkit#1221) with an additional commit to move the payment_secret and the payment_metadata into a new struct called RecipientInfo. This will allow us to add custom onion TLVs, see [discussion](lightningdevkit#1298 (comment)) No logic change, just lots of plumbing.
andozw
added a commit
to andozw/rust-lightning
that referenced
this pull request
Apr 22, 2022
This work is a pre-req for [Issue-1298](lightningdevkit#1298). This is a rebase of [PR-1221](lightningdevkit#1221) with an additional commit to move the payment_secret and the payment_metadata into a new struct called RecipientInfo. This will allow us to add custom onion TLVs, see [discussion](lightningdevkit#1298 (comment)) No logic change, just lots of plumbing.
andozw
added a commit
to andozw/rust-lightning
that referenced
this pull request
Apr 22, 2022
This work is a pre-req for [Issue-1298](lightningdevkit#1298). This is a rebase of [PR-1221](lightningdevkit#1221) with an additional commit to move the payment_secret and the payment_metadata into a new struct called RecipientInfo. This will allow us to add custom onion TLVs, see [discussion](lightningdevkit#1298 (comment)) No logic change, just lots of plumbing.
|
Superceded by #1445. |
This was referenced Apr 22, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As specified by lightning/bolts#912. All pretty straightforward, just a lot of plumbing.