Skip to content

Refuse new updates after the ChannelMonitor has seen a funding spend confirmed #2013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wpaulino opened this issue Feb 6, 2023 · 5 comments
Closed

Refuse new updates after the ChannelMonitor has seen a funding spend confirmed #2013

wpaulino opened this issue Feb 6, 2023 · 5 comments
Labels
good first issue Good for newcomers
Milestone
0.1

Comments

@wpaulino
Copy link
Contributor

wpaulino commented Feb 6, 2023

Requested as a follow-up in #1922 (comment).
@wpaulino wpaulino added the good first issue Good for newcomers label Feb 6, 2023
@TheBlueMatt TheBlueMatt added this to the 0.1 milestone Feb 6, 2023
@amit-62
Copy link

amit-62 commented Feb 7, 2023

Hello @wpaulino I want to solve this issue. But I am new to this repo and need guidance to solve it.

@TheBlueMatt
Copy link
Collaborator

See the linked comment - the new channelmonitor code in that pr should be roughly copied into the mentioned method and the update refused if it hits.

@amit-62
Copy link

amit-62 commented Feb 8, 2023

Thank you @TheBlueMatt

@amit-62
Copy link

amit-62 commented Feb 16, 2023 •
edited
Loading

Hello @TheBlueMatt I have created PR #2038 please review and suggest improvement.
Thank you.

@amit-62 amit-62 mentioned this issue Feb 16, 2023
Closed
@TheBlueMatt
Copy link
Collaborator

Fixed in #2265.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
0.1
Development

Successfully merging a pull request may close this issue.

Updated provide_latest_holder_commitment_tx. amit-62/rust-lightning
3 participants
@TheBlueMatt @wpaulino @amit-62