Skip to content

Feature request: basePenaltyPpm #1616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ddiekroeger opened this issue Jul 14, 2022 · 0 comments · Fixed by #1617
Closed

Feature request: basePenaltyPpm #1616

ddiekroeger opened this issue Jul 14, 2022 · 0 comments · Fixed by #1617

Comments

@ddiekroeger
Copy link

I like the basePenaltyMsat parameter for ProbabilisticScoringParams, but it isn't great at adjusting for different payment sizes. Would it make sense to add a basePenaltyPpm option that sets a base penalty proportional to the payment size?

TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Jul 14, 2022
There's not much reason to not have a per-hop-per-amount penalty in
the `ProbabilisticScorer` to go along with the per-hop penalty to
let it scale up to larger amounts, so we add one here.

Notably, we use a divisor of 2^30 instead of 2^20 (like the
equivalent liquidity penalty) as it allows for more flexibility,
and there's not really any reason to worry about us not being able
to create high enough penalties.

Closes lightningdevkit#1616
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Jul 14, 2022
There's not much reason to not have a per-hop-per-amount penalty in
the `ProbabilisticScorer` to go along with the per-hop penalty to
let it scale up to larger amounts, so we add one here.

Notably, we use a divisor of 2^30 instead of 2^20 (like the
equivalent liquidity penalty) as it allows for more flexibility,
and there's not really any reason to worry about us not being able
to create high enough penalties.

Closes lightningdevkit#1616
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Jul 15, 2022
There's not much reason to not have a per-hop-per-amount penalty in
the `ProbabilisticScorer` to go along with the per-hop penalty to
let it scale up to larger amounts, so we add one here.

Notably, we use a divisor of 2^30 instead of 2^20 (like the
equivalent liquidity penalty) as it allows for more flexibility,
and there's not really any reason to worry about us not being able
to create high enough penalties.

Closes lightningdevkit#1616
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Jul 15, 2022
There's not much reason to not have a per-hop-per-amount penalty in
the `ProbabilisticScorer` to go along with the per-hop penalty to
let it scale up to larger amounts, so we add one here.

Notably, we use a divisor of 2^30 instead of 2^20 (like the
equivalent liquidity penalty) as it allows for more flexibility,
and there's not really any reason to worry about us not being able
to create high enough penalties.

Closes lightningdevkit#1616
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Jul 19, 2022
There's not much reason to not have a per-hop-per-amount penalty in
the `ProbabilisticScorer` to go along with the per-hop penalty to
let it scale up to larger amounts, so we add one here.

Notably, we use a divisor of 2^30 instead of 2^20 (like the
equivalent liquidity penalty) as it allows for more flexibility,
and there's not really any reason to worry about us not being able
to create high enough penalties.

Closes lightningdevkit#1616
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Jul 25, 2022
There's not much reason to not have a per-hop-per-amount penalty in
the `ProbabilisticScorer` to go along with the per-hop penalty to
let it scale up to larger amounts, so we add one here.

Notably, we use a divisor of 2^30 instead of 2^20 (like the
equivalent liquidity penalty) as it allows for more flexibility,
and there's not really any reason to worry about us not being able
to create high enough penalties.

Closes lightningdevkit#1616
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant