Skip to content

Fix (+test) phantom node onion error returning #1308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TheBlueMatt opened this issue Feb 15, 2022 · 1 comment · Fixed by #1324
Closed

Fix (+test) phantom node onion error returning #1308

TheBlueMatt opened this issue Feb 15, 2022 · 1 comment · Fixed by #1324
Assignees
@valentinewallace
Milestone
0.0.105

Comments

@TheBlueMatt
Copy link
Collaborator

See #1199 (comment) and the following comment, probably need to test al the cases where we return onion errors in that function. Also some nits worth hitting at #1199 (review)
@TheBlueMatt TheBlueMatt added this to the 0.0.105 milestone Feb 15, 2022
@TheBlueMatt TheBlueMatt mentioned this issue Feb 15, 2022
Merged
@jkczyz
Copy link
Contributor

jkczyz commented Feb 15, 2022

Also want to tag module-level docs for follow up, but wouldn't mind leaving for a more general documentation clean-up. #1199 (review)

@valentinewallace valentinewallace mentioned this issue Feb 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentinewallace valentinewallace

Labels
None yet
Projects
None yet
Milestone
0.0.105
Development

Successfully merging a pull request may close this issue.

#1199 Followup valentinewallace/rust-lightning
3 participants
@TheBlueMatt @jkczyz @valentinewallace