Skip to content

Do not treat UnknownRequiredFeature as always a gossip failure #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TheBlueMatt opened this issue Jan 11, 2022 · 0 comments · Fixed by #1283
Closed

Do not treat UnknownRequiredFeature as always a gossip failure #1236

TheBlueMatt opened this issue Jan 11, 2022 · 0 comments · Fixed by #1283
Assignees
@TheBlueMatt
Milestone
0.0.105

Comments

@TheBlueMatt
Copy link
Collaborator

See #1013 (comment) it seems this can be hit from any even TLV that we don't understand, which shouldn't just be a warning + ignore
@TheBlueMatt TheBlueMatt modified the milestones: 0.1, 0.0.105 Jan 11, 2022
@TheBlueMatt TheBlueMatt self-assigned this Jan 24, 2022
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Jan 26, 2022
@TheBlueMatt
Correct handling of UnknownRequiredFeature deserialization
9463913 
Quite some time ago, `UnknownRequiredFeature` was only used when a
gossip message has a missing required feature. These days, its also
used for any required TLV which we do not understand in any
message. However, the handling of it was never updated in
`PeerManager`, leaving it printing a warning about gossip and
ignoring the message entirely.

Instead, we send a warning message and disconnect.

Closes lightningdevkit#1236, as caught by @jkczyz.
@TheBlueMatt TheBlueMatt mentioned this issue Jan 26, 2022
Merged
ViktorTigerstrom pushed a commit to ViktorTigerstrom/rust-lightning that referenced this issue Mar 2, 2022
@TheBlueMatt @ViktorTigerstrom
Correct handling of UnknownRequiredFeature deserialization
5ca2fd6 
Quite some time ago, `UnknownRequiredFeature` was only used when a
gossip message has a missing required feature. These days, its also
used for any required TLV which we do not understand in any
message. However, the handling of it was never updated in
`PeerManager`, leaving it printing a warning about gossip and
ignoring the message entirely.

Instead, we send a warning message and disconnect.

Closes lightningdevkit#1236, as caught by @jkczyz.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheBlueMatt TheBlueMatt

Labels
None yet
Projects
None yet
Milestone
0.0.105
Development

Successfully merging a pull request may close this issue.

Correct handling of UnknownRequiredFeature deserialization TheBlueMatt/rust-lightning
1 participant
@TheBlueMatt