Skip to content

Refactored clippy suggestion to improve readability #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2024
Merged

Refactored clippy suggestion to improve readability #287

merged 1 commit into from
May 13, 2024

Conversation

srikanth-iyengar
Copy link
Contributor

@srikanth-iyengar srikanth-iyengar commented Apr 30, 2024 •
edited
Loading

  • Removed a redundant variable shadowing in builder.rs
  • Passed directly the closure itself instead of making a inline closure
  • Refactored usage of map which returns boolean to matches!

@srikanth-iyengar srikanth-iyengar marked this pull request as draft April 30, 2024 17:37
@srikanth-iyengar srikanth-iyengar changed the title Refactored necessary clippy suggestion to improve readability Refactored clippy suggestion to improve readability May 9, 2024
tnull
tnull reviewed May 12, 2024
View reviewed changes
Copy link
Collaborator

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, changes look reasonable, but this needs some formatting changes now (i.e. a run of cargo fmt).

@srikanth-iyengar
Copy link
Contributor Author

Thanks @tnull, I have done the formatting changes
Will try to fix the failing CI

@tnull
Copy link
Collaborator

tnull commented May 12, 2024

Thanks @tnull, I have done the formatting changes Will try to fix the failing CI

Ah, the failing CI is unrelated and will be fixed in an upcoming PR upgrading rust-lightning to the 0.0.123 release. I'll open it tomorrow, so fee free to hold off until then.

@srikanth-iyengar
Copy link
Contributor Author

Alright

@srikanth-iyengar srikanth-iyengar marked this pull request as ready for review May 13, 2024 12:53
@tnull
Copy link
Collaborator

tnull commented May 13, 2024

Alright

The CI failure was addressed in #291. Please rebase to make it pass.

@srikanth-iyengar
Refactored necessary files to improve code quality
4d7c9f3 
* Removed a useless shadowing in builder.rs
* Passed directly the closure itself instead of making a inline closure
* Refactored usage of map which returns boolean to matches!
@srikanth-iyengar
Copy link
Contributor Author

The CI failure was addressed in #291. Please rebase to make it pass.

Rebased with main, all checks passed

tnull
tnull approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tnull tnull merged commit e14b70e into lightningdevkit:main May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnull tnull tnull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srikanth-iyengar @tnull