Skip to content

Fix text width handling in inspector #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pecoram wants to merge 1 commit into
base: v2
Choose a base branch
from
Open

Fix text width handling in inspector #672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion exports/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,10 @@ export {
export type { ShaderMap, EffectMap } from '../src/core/CoreShaderManager.js';
export type { TextRendererMap } from '../src/core/text-rendering/renderers/TextRenderer.js';
export type { TrFontFaceMap } from '../src/core/text-rendering/font-face-types/TrFontFace.js';
export type { AnimationSettings } from '../src/core/animations/CoreAnimation.js';
export type {
AnimationSettings,
CoreAnimation,
} from '../src/core/animations/CoreAnimation.js';
export type {
EffectProps,
FadeOutEffectProps,
Expand All @@ -75,6 +78,8 @@ export type { WebGlCoreCtxTexture } from '../src/core/renderers/webgl/WebGlCoreC
export type { Inspector } from '../src/main-api/Inspector.js';
export type { CoreNodeRenderState } from '../src/core/CoreNode.js';

export type { CoreRenderer } from '../src/core/renderers/CoreRenderer.js';

// Shaders
export * from '../src/core/renderers/webgl/WebGlCoreShader.js';
export * from '../src/core/renderers/webgl/shaders/effects/ShaderEffect.js';
Expand Down
10 changes: 3 additions & 7 deletions src/main-api/Inspector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,16 +52,14 @@ const stylePropertyMap: {
},
width: (w) => {
if (w === 0) {
// Set to 1px instead of 0px so visibility checks (e.g. Playwright) keep treating the node as visible
return { prop: 'width', value: '1px' };
return { prop: 'width', value: 'auto' };
}

return { prop: 'width', value: `${w}px` };
},
height: (h) => {
if (h === 0) {
// Set to 1px instead of 0px so visibility checks (e.g. Playwright) keep treating the node as visible
return { prop: 'height', value: '1px' };
return { prop: 'height', value: 'auto' };
}

return { prop: 'height', value: `${h}px` };
Expand Down Expand Up @@ -577,9 +575,7 @@ export class Inspector {
// special case for text
if (property === 'text') {
div.innerHTML = String(value);

// Keep DOM text invisible without breaking visibility checks by using color:transparent instead of opacity:0
div.style.color = 'transparent';
div.style.visibility = 'hidden';
div.style.pointerEvents = 'none';
div.style.userSelect = 'none';
return;
Expand Down
Loading