Skip to content

Conversation

@chiefcll
Copy link
Contributor

@chiefcll chiefcll commented Oct 8, 2025

  1. Back ported the isProductionEnvironment so AssertTruthy can be tree shaken
  2. Back port exporting of utils
  3. Optimize WebGL loop as Shaders are ALWAYS defined on CoreNode and shaderProps as well.

Requires DEV to be added to vite config.

@chiefcll
Copy link
Contributor Author

chiefcll commented Oct 8, 2025

I've dived into this and think the test is broken.

Expected:
rtt-dimension-6-expected

With the changes we get:
rtt-dimension-6-actual

Which is what it should be. The "expected" is turning off RTT and not processing its children nodes to update what should be rendered. Here is the code:

image

When RTT is turned off child colors should be present...

@jfboeve
Copy link
Collaborator

jfboeve commented Oct 13, 2025

Hmm I double checked the code, but it does seem that the "expected" screen shot is incorrect. So I think the vrt screenshot needs to be overwritten

Copy link
Collaborator

@jfboeve jfboeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vrt screenshot needs to be updated

@chiefcll
Copy link
Contributor Author

Update the VRT and fixed up merge conflict

@chiefcll chiefcll requested a review from jfboeve October 23, 2025 03:25
@jfboeve jfboeve merged commit a42b511 into lightning-js:v2 Oct 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants