Skip to content

Conversation

@elsassph
Copy link
Contributor

@elsassph elsassph commented Jul 2, 2024

Implements #316

scaleRotateTransform matrix is a waste of memory and computations when rotation=0 and scale=1, which will be the case 99.9% of the time in an average app.

@elsassph elsassph changed the base branch from main to dev July 2, 2024 13:00
Copy link
Contributor

@frank-weindel frank-weindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@frank-weindel frank-weindel merged commit 953eee6 into lightning-js:dev Jul 3, 2024
@frank-weindel frank-weindel linked an issue Jul 6, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CoreNode: Only create scaleRotateTransform matrix when needed

2 participants