Fix: wrong load external resources when the local protocol is file:// #309
Conversation
src/core/lib/utils.ts
Outdated
| // handle local file imports if the url isn't remote resource or data blob | ||
| if ( | ||
| self.location.protocol === 'file:' && | ||
| !EXTERNAL_REGEX_URL.test(url) && |
There was a problem hiding this comment.
Looks like all cases could be a single regex, if you just test /^(data|https?|ftps?):/
There was a problem hiding this comment.
And TBH, you could simplify further by just checking whether it looks like {protocol}:
There was a problem hiding this comment.
@elsassph Thanks, I fixed it! Simplify as {protocol}:
There was a problem hiding this comment.
Cool, I thought it might be simpler/safer to not test the protocol itself, e.g. any ^[a-z]+: is a protocol.
There was a problem hiding this comment.
@elsassph I prefer to have a more specific check based on protocol resources.
IMO your suggestion is too generic.
What happen if you have an local image with filename like aaa:2222.png?
wouterlucas
left a comment
wouterlucas
left a comment
There was a problem hiding this comment.
Good catch 😅 thanks! 😄
4 participants
When an external image resource is loaded from https, the function convertUrlToAbsolute inside the utils.ts doesn't check if it is a network or internal resource.