passing renderCoords from CoreNode to addQuad #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfboeve
requested review from
erikhaandrikman,
frank-weindel and
wouterlucas
and removed request for
erikhaandrikman
| uiQuadBuffer[bufferIdx++] = colorBr; | ||
| fQuadBuffer[bufferIdx++] = textureIdx; | ||
| // render quad advanced | ||
| if (tb !== 0 || tc !== 0) { |
Contributor
There was a problem hiding this comment.
Could you move this conditional block up a level to be an else if + else? Just to reduce indentation where it isn't really needed
frank-weindel
approved these changes
Jun 17, 2024
erikhaandrikman
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using the same calculations for the renderCoords we use in the .addQuad function in the WebGLCoreRenderer, with this fix we can use the already calculated renderCoords without having to do the calculations again every time a draw call is made.