Skip to content

Fix multiple text issues #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2024
Merged

Fix multiple text issues #164

merged 1 commit into from
Feb 9, 2024

Conversation

@frank-weindel
Copy link
Contributor

@frank-weindel frank-weindel commented Feb 6, 2024 •
edited
Loading

Fixes #163, fixes #162, fixes #48

@frank-weindel
Fix multiple text issues
0849512 
- Canvas Text: Support contain both (#163)
- Canvas Text: Not fully updating when contain property is changed (#162)
- SDF Text: height(with contain both) doesn't crop correctly (#48)

Fixes #163, #162, #48
wouterlucas
wouterlucas approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@wouterlucas wouterlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@frank-weindel frank-weindel added this pull request to the merge queue Feb 8, 2024
Merged via the queue into main with commit c945c32 Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wouterlucas wouterlucas wouterlucas approved these changes

@michielvandergeest michielvandergeest Awaiting requested review from michielvandergeest

@erikhaandrikman erikhaandrikman Awaiting requested review from erikhaandrikman

+1 more reviewer

@chiefcll chiefcll chiefcll approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

4 participants

@frank-weindel @wouterlucas @chiefcll