Skip to content

SDF: Implement lineHeight, verticalAlign, maxLines, overflowSuffix #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
frank-weindel merged 2 commits into from
Jan 24, 2024
Merged

SDF: Implement lineHeight, verticalAlign, maxLines, overflowSuffix #136

frank-weindel merged 2 commits into from
Jan 24, 2024

Conversation

@frank-weindel
Copy link
Contributor

@frank-weindel frank-weindel commented Jan 24, 2024

Fixes #107

@frank-weindel
Copy link
Contributor Author

frank-weindel commented Jan 24, 2024

@chiefcll This doesn't yet include the x/y optimization you requested. I'm working on that in a separate PR. However, some of the refactoring I did should reduce the number of calculations we do while laying out text so it's worth checking this for it's performance.

@chiefcll
Copy link
Contributor

chiefcll commented Jan 24, 2024

Code looks great - tests + screenshots. Going to run this locally and check out the Pi in a bit

@frank-weindel
Copy link
Contributor Author

frank-weindel commented Jan 24, 2024

@chiefcll Just pushed another commit that reduces some more calculations

@frank-weindel frank-weindel added this pull request to the merge queue Jan 24, 2024
Merged via the queue into main with commit 9e10f03 Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wouterlucas wouterlucas Awaiting requested review from wouterlucas

@michielvandergeest michielvandergeest Awaiting requested review from michielvandergeest

@erikhaandrikman erikhaandrikman Awaiting requested review from erikhaandrikman

1 more reviewer

@chiefcll chiefcll chiefcll approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement missing text props in the SDF Text Renderer

2 participants

@frank-weindel @chiefcll