LPD-62912 Add support for Microsoft SQL Server 2022 #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthony-chu
changed the title
drewbrokke
reviewed
Oct 13, 2025
| String schema -> | ||
|
|
||
| executeSQLQuery("update ObjectValidationRule set active_ = false where objectDefinitionId in (select objectDefinitionId from ObjectDefinition where externalReferenceCode = 'L_USER')", schema) | ||
| executeSQLQuery("update ObjectValidationRule set active_ = 'false' where objectDefinitionId in (select objectDefinitionId from ObjectDefinition where externalReferenceCode = 'L_USER')", schema) |
There was a problem hiding this comment.
How is this issue observed? Is this backwards compatible with other database types?
There was a problem hiding this comment.
initially, it gives a unhelpful exception:
java.lang.IndexOutOfBoundsException: Index 1 out of bounds for length 1
this comes from the attempt to parse the results of the executed sql query. printing out the actual bare result that comes back from the query, the following response is given:
[Msg 207, Level 16, State 1, Server 804fb429fda5, Line 1, Invalid column name 'false'.]
for SQL Server, false is a reserved keyword. in order to be used as a string, it needs to be quoted.
i had not tested it for other databases. i did just now, and other databases don't accept the single-quotes around false, so added a check for the database to determine which sql statement to use.
i'll send a follow-up PR to address the other DBs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://liferay.atlassian.net/browse/LPD-62912