[VAULTS] Accounting Oracle #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

F4ever merged 415 commits into develop from feat/vaults-pectra

Oct 6, 2025

Member

tamtamchik commented Mar 21, 2025 •

edited

Loading

Base PR for Lido V3 accounting oracle

F4ever changed the base branch from develop to feat/oracle-v6

March 25, 2025 12:59

F4ever reviewed

View reviewed changes

src/modules/accounting/accounting.py Outdated Show resolved Hide resolved

F4ever reviewed

View reviewed changes

src/modules/accounting/types.py Outdated Show resolved Hide resolved

F4ever reviewed

View reviewed changes

src/providers/execution/contracts/accounting.py Outdated Show resolved Hide resolved

F4ever reviewed

View reviewed changes

src/providers/execution/contracts/vault_hub.py Outdated Show resolved Hide resolved

F4ever reviewed

View reviewed changes

src/web3py/extensions/staking_vaults.py Outdated Show resolved Hide resolved

F4ever reviewed

View reviewed changes

src/web3py/extensions/staking_vaults.py Outdated Show resolved Hide resolved

tamtamchik force-pushed the feat/vaults-pectra branch from a0d9257 to a61cce2 Compare

March 25, 2025 14:06

F4ever reviewed

View reviewed changes

src/providers/consensus/client.py Outdated Show resolved Hide resolved

tamtamchik changed the title ~~feat: vaults pectra~~ feat: vaults devnet oracle

sergeyWh1te force-pushed the feat/vaults-pectra branch 3 times, most recently from 1f42b73 to ea2ed0e Compare

April 2, 2025 11:48

sergeyWh1te self-assigned this

Contributor

sergeyWh1te commented Apr 2, 2025

collapse: abi
transfer staking_vault -> modules/accounting
contracts loading moved -> web3py/extentions/contract
AccountingContract.handle_oracle_report - place as is - agreed with @F4ever that they'll fix that
Integration tests - are broken. It's not trivial work - agreed with @F4ever that they or we'll collaborate how to fix tests when @F4ever will figure out "how" to fix them

cc @tamtamchik @vp4242

sergeyWh1te requested a review from F4ever

April 2, 2025 13:16

Contributor

sergeyWh1te commented Apr 9, 2025

Screenshot 2025-04-09 at 3 43 07 PM

On local machine with sepolia urls

sergeyWh1te requested a review from chasingrainbows

April 9, 2025 14:12

chasingrainbows reviewed

View reviewed changes

src/main.py Outdated Show resolved Hide resolved

chasingrainbows reviewed

View reviewed changes

src/main.py Outdated Show resolved Hide resolved

chasingrainbows reviewed

View reviewed changes

src/modules/accounting/staking_vaults.py Outdated Show resolved Hide resolved

chasingrainbows reviewed

View reviewed changes

src/modules/accounting/staking_vaults.py Outdated Show resolved Hide resolved

chasingrainbows reviewed

View reviewed changes

src/modules/accounting/staking_vaults.py Outdated Show resolved Hide resolved

chasingrainbows reviewed

View reviewed changes

src/modules/accounting/staking_vaults.py Outdated Show resolved Hide resolved

chasingrainbows reviewed

View reviewed changes

src/modules/accounting/staking_vaults.py Outdated Show resolved Hide resolved

chasingrainbows reviewed

View reviewed changes

src/modules/accounting/types.py Outdated Show resolved Hide resolved

chasingrainbows reviewed

View reviewed changes

tests/conftest.py Outdated Show resolved Hide resolved

chasingrainbows reviewed

View reviewed changes

tests/modules/accounting/staking_vault/test_staking_vaults.py Outdated Show resolved Hide resolved

chasingrainbows reviewed

View reviewed changes

tests/modules/accounting/staking_vault/test_staking_vaults_smoke.py Outdated Show resolved Hide resolved

F4ever marked this pull request as draft

April 15, 2025 21:42

tamtamchik added 17 commits

September 21, 2025 17:19


          feat(vaults): use new locator

2184a85


          chore: fixes

a4eeedc


          feat(vaults): merge master

a1a0f4c


          Merge branch 'feat/fix-for-pdg-flow' into feat/fix-775

72d179d

# Conflicts:
#	src/modules/accounting/types.py


          feat(vaults): minify abis

a821906


          chore: after review

d3340cf


          feat(vaults): fix or skip tests

f0b6357


          Merge pull request #787 from lidofinance/feat/fix-775

7582f00

feat: fix share_rate and add max liability shares


          feat: use lazy oracle to check validator stages

5e65030


          chore: please linter

fc01b1d


          feat: add integration tests for lazy oracle

b32eda8


          Merge remote-tracking branch 'origin/fix/finalization-batches-build' …

64f5d30

…into feat/audits-3

# Conflicts:
#	pyproject.toml


          Merge branch 'feat/audits-3' into feat/validator-stages

ef7eec8


          chore: apply review comments

822dd3d


          Merge branch 'develop' into feat/validator-stages

30090cf

# Conflicts:
#	pyproject.toml


          chore: apply review comments

0a45d61


          chore: fixes after review

d5a05c3

tamtamchik added the Lido V3 label

tamtamchik and others added 6 commits

October 1, 2025 10:38


          Merge pull request #790 from lidofinance/feat/validator-stages

233f6de

feat: use lazy oracle to check validator stages


          fix: h-02 – double counting

ecb54a9


          feat(vaults): fix test

dc9b64e


          feat: bump ao contract version

bb0a191


          Fix csm test

09c8a92


          Merge pull request #784 from lidofinance/feat/vaults-testnet-3

42f936e

[VAULTS]: Audit fixes 2

tamtamchik changed the title ~~feat: stVaults Oracle~~ [VAULTS] Accounting Oracle

tamtamchik self-assigned this

TheDZhon approved these changes

View reviewed changes

TheDZhon left a comment

LGTM, just a few non-blocking questions

src/modules/csm/csm.py Show resolved Hide resolved

src/modules/csm/distribution.py Show resolved Hide resolved

src/providers/ipfs/kubo.py Show resolved Hide resolved

F4ever approved these changes

View reviewed changes

F4ever merged commit aa8e08b into develop

10 of 15 checks passed

F4ever deleted the feat/vaults-pectra branch

October 6, 2025 14:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

folkyatina folkyatina left review comments

hweawer hweawer left review comments

TheDZhon TheDZhon approved these changes

F4ever F4ever approved these changes

chasingrainbows chasingrainbows left review comments

+1 more reviewer

sergeyWh1te sergeyWh1te left review comments

Labels