read battery.temperature or ups.temperature #582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
VVelox
requested changes
Sep 18, 2025
Collaborator
VVelox
left a comment
VVelox
left a comment
There was a problem hiding this comment.
This should likely make use of head -n 1 to ensure there is only one in case there is both. That or check for one and then use the other if not found.
Contributor
Author
|
@VVelox: not sure what you mean. this is taken care of in line 43. |
VVelox
approved these changes
Sep 22, 2025
Collaborator
|
@osiktech derp! missed that =^.^= |
Contributor
Author
|
@VVelox: no worries, better to check twice. I could have made a mistake 😉 |
Collaborator
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have two UPSs from APC. One reports battery.temperature the other ups.temperature. This small fix should fix to get a temperature reading.