fix: promisified methods #398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test(fix): fix tests with latest ws rendezvous server
test: add tests to verify promisify support until async/await endeavor is complete
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Jun 21, 2023
Updates to latest metrics interface. BREAKING CHANGE: requires @libp2p/interface-metrics v4
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Jun 21, 2023
## [6.0.0](libp2p/js-libp2p-kad-dht@v5.0.2...v6.0.0) (2022-11-05) ### ⚠ BREAKING CHANGES * requires @libp2p/interface-metrics v4 ### Bug Fixes * update to metrics v4 ([libp2p#398](libp2p/js-libp2p-kad-dht#398)) ([3182cb0](libp2p/js-libp2p-kad-dht@3182cb0))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a residual issue from #394 that I noticed when upgrading to the latest websocket star rendezvous server (async updates) for the tests. I've corrected this and added some additional tests to verify the promisified code is executing as expected to we avoid any further regressions during the async/await migration.
I also updated tests associated with the ws-star server updates so that they are once again passing.