chore: reintroduce webRTC + webRTC direct interop tests #2232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maschad
changed the title
Member
|
Tests will be fixed by #2234 |
achingbrain
reviewed
Nov 15, 2023
achingbrain
reviewed
Nov 15, 2023
achingbrain
reviewed
Nov 15, 2023
achingbrain
approved these changes
Nov 15, 2023
maschad
added a commit
to maschad/js-libp2p
that referenced
this pull request
Nov 27, 2023
There have been a lot of fixes added to webRTC and the interop tests appear more stable so re-add them to every test run. --------- Co-authored-by: Alex Potsides <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
chore: reintroduce webRTC and webRTC direct transport interop tests
Description
There has been a lot of fixes added to webRTC and so following the removal #1845 due to flakiness as mentioned here #1846 we want to see if these fixes have resolved the issues.
Notes & open questions
Change checklist