fix!: remove dialler language #2085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maschad
requested changes
Oct 2, 2023
Member
maschad
left a comment
maschad
left a comment
There was a problem hiding this comment.
II can agree to the metric name change but I left a comment re: the variable name changes
Closed
maschad
approved these changes
Oct 6, 2023
Member
|
Can you hold off merging breaking changes for the time being please, we’ll get these all in for v1 |
Merged
Member
|
I'm going to revert this so we can get the bug fix in #2139 out without needing a major release. |
Member
|
Re-opened here: #2143 |
achingbrain
pushed a commit
that referenced
this pull request
Oct 25, 2023
* fix!: remove dialler language * chore: address pr comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description