Skip to content

fix: update max message size SDP attribute #1909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2023
Merged

fix: update max message size SDP attribute #1909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/transport-webrtc/src/private-to-public/sdp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ a=ice-ufrag:${ufrag}
a=ice-pwd:${ufrag}
a=fingerprint:${CERTFP}
a=sctp-port:5000
a=max-message-size:100000
a=max-message-size:16384
a=candidate:1467250027 1 UDP 1467250027 ${host} ${port} typ host\r\n`
}

Expand Down
4 changes: 2 additions & 2 deletions packages/transport-webrtc/test/sdp.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ a=ice-ufrag:MyUserFragment
a=ice-pwd:MyUserFragment
a=fingerprint:SHA-256 72:68:47:CD:48:B0:5E:C5:60:4D:15:9C:BF:40:1D:6F:00:A1:23:EC:90:17:0E:2C:D1:B3:8F:D2:9D:37:E5:B1
a=sctp-port:5000
a=max-message-size:100000
a=max-message-size:16384
a=candidate:1467250027 1 UDP 1467250027 0.0.0.0 56093 typ host`

describe('SDP', () => {
Expand Down Expand Up @@ -73,7 +73,7 @@ a=ice-ufrag:someotheruserfragmentstring
a=ice-pwd:someotheruserfragmentstring
a=fingerprint:SHA-256 72:68:47:CD:48:B0:5E:C5:60:4D:15:9C:BF:40:1D:6F:00:A1:23:EC:90:17:0E:2C:D1:B3:8F:D2:9D:37:E5:B1
a=sctp-port:5000
a=max-message-size:100000
a=max-message-size:16384
a=candidate:1467250027 1 UDP 1467250027 0.0.0.0 56093 typ host`

expect(result.sdp).to.equal(expected)
Expand Down