-
Notifications
You must be signed in to change notification settings - Fork 501
chore: convert to monorepo #1792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
2a82858
9565b49
32ea8e4
905aa07
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -159,18 +159,34 @@ jobs: | |
|
||
release: | ||
runs-on: ubuntu-latest | ||
needs: [test-node, test-chrome, test-chrome-webworker, test-firefox, test-firefox-webworker, test-electron-main, test-electron-renderer, test-interop] | ||
needs: [ | ||
test-node, | ||
test-chrome, | ||
test-chrome-webworker, | ||
test-firefox, | ||
test-firefox-webworker, | ||
test-electron-main, | ||
test-electron-renderer, | ||
test-interop | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. test-examples? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Examples are tested in a separate workflow file, I don't think you can depend on jobs defined in other files yet. |
||
] | ||
if: github.event_name == 'push' && github.ref == 'refs/heads/master' | ||
steps: | ||
- uses: GoogleCloudPlatform/release-please-action@v2 | ||
id: release | ||
with: | ||
token: ${{ secrets.GITHUB_TOKEN }} | ||
command: manifest | ||
release-type: node | ||
# breaking changes should rev the minor (remove after v1) | ||
maschad marked this conversation as resolved.
Show resolved
Hide resolved
|
||
bump-minor-pre-major: true | ||
# features should rev the patch (remove after v1) | ||
bump-patch-for-minor-pre-major: true | ||
manifest-file: .release-please-manifest.json | ||
config-file: .release-please.json | ||
changelog-types: | | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I do think this will be good addition to help enforce conventional commits but is it directly related to monorepo work? May be better for a follow up PR so that we can discuss the conventions. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, this was copied from the js-ipfs workflow which uses release please to do gated monorepo releases. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Gotcha, and release please looks for Conventional Commit messages to automate our releases. I personally prefer this style of conventional commits but I was just making a suggestion for a discussion before going ahead with it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There's not much to discuss - the commit style is the same as it was before, this is just config necessary to get release please to perform the gated releases as before. |
||
[ | ||
{ "type": "feat", "section": "Features", "hidden": false }, | ||
{ "type": "fix", "section": "Bug Fixes", "hidden": false }, | ||
{ "type": "chore", "section": "Trivial Changes", "hidden": false }, | ||
{ "type": "docs", "section": "Documentation", "hidden": false }, | ||
{ "type": "deps", "section": "Dependencies", "hidden": false } | ||
] | ||
- uses: actions/checkout@v3 | ||
with: | ||
fetch-depth: 0 | ||
|
@@ -179,23 +195,21 @@ jobs: | |
node-version: lts/* | ||
registry-url: 'https://registry.npmjs.org' | ||
- uses: ipfs/aegir/actions/cache-node-modules@master | ||
- if: ${{ steps.release.outputs.release_created }} | ||
name: Generate typedoc URLs | ||
run: npm --if-present run docs -- --publish false | ||
- if: ${{ steps.release.outputs.release_created }} | ||
- uses: ipfs/aegir/actions/docker-login@master | ||
with: | ||
docker-token: ${{ secrets.DOCKER_TOKEN }} | ||
docker-username: ${{ secrets.DOCKER_USERNAME }} | ||
- if: ${{ steps.release.outputs.releases_created }} | ||
name: Run release version | ||
run: npm publish | ||
run: | | ||
git update-index --assume-unchanged packages/libp2p/src/version.ts | ||
npm run --if-present release | ||
env: | ||
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} | ||
- if: ${{ steps.release.outputs.release_created }} | ||
name: Publish docs | ||
run: npm run --if-present docs | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
- if: ${{ !steps.release.outputs.release_created }} | ||
- if: ${{ !steps.release.outputs.releases_created }} | ||
name: Run release rc | ||
run: | | ||
npm version `node -p -e "require('./package.json').version"`-`git rev-parse --short HEAD` --no-git-tag-version | ||
npm publish --tag next | ||
git update-index --assume-unchanged packages/libp2p/src/version.ts | ||
npm run --if-present release:rc | ||
env: | ||
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"packages/libp2p":"0.45.6" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
{ | ||
"plugins": ["node-workspace"], | ||
"bump-minor-pre-major": true, | ||
"bump-patch-for-minor-pre-major": true, | ||
"group-pull-request-title-pattern": "chore: release ${component}", | ||
"packages": { | ||
"packages/libp2p": {} | ||
} | ||
} |
This file was deleted.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.