Skip to content

fix: Remove stream from registry after it's closed #1612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

fix: Remove stream from registry after it's closed #1612

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dc8949e
fix: Remove stream from registry after it's closed
maschad Mar 3, 2023
94d1c4f
fix: handle case where stream doesn't exist in array + added tests (#…
maschad Mar 9, 2023
517c743
Merge branch 'master' into fix/remove-stream-registry
maschad Mar 9, 2023
ab06782
Merge branch 'master' into fix/remove-stream-registry
maschad Mar 15, 2023
4e423cb
chore: added return type for linting on removeStream
maschad Mar 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/connection/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ export class ConnectionImpl implements Connection {
* Remove stream registry after it is closed
*/
removeStream (id: string) {

this.streams.splice(this.streams.findIndex(s => s.id === id), 1)
}

/**
Expand Down