-
Notifications
You must be signed in to change notification settings - Fork 499
Closed
Labels
P1High: Likely tackled by core team if no one steps upHigh: Likely tackled by core team if no one steps updxDeveloper ExperienceDeveloper Experiencekind/bugA bug in existing code (including security flaws)A bug in existing code (including security flaws)
Description
Node 15 includes npm 7 which now automatically installs peer dependencies by default, https://github.blog/2020-10-13-presenting-v7-0-0-of-the-npm-cli/.
This change also affects how we're linking libp2p
itself in the devDependencies to make integration testing with modules like gossipsub easier (as it requires libp2p as a peerDependency).
Ideally we'd remove the local integration testing of modules and instead run their test suites in CI and test only the core API in the libp2p
test suite. In the immediate term we should find a workaround for "libp2p": "."
being in the devDependencies.
Metadata
Metadata
Assignees
Labels
P1High: Likely tackled by core team if no one steps upHigh: Likely tackled by core team if no one steps updxDeveloper ExperienceDeveloper Experiencekind/bugA bug in existing code (including security flaws)A bug in existing code (including security flaws)
Type
Projects
Status
🎉Done