Connection drop causes gossipsub to stop working

[jacobheun]

• Version: 0.28.0
• Platform: Node.js and Browser
• Subsystem: Gossipsub/Pubsub

Type: Bug

Severity: High

Description:

I was updated the Chat example at https://github.com/libp2p/js-libp2p-examples/tree/libp2p-0.28.x/chat to 0.28.x. When a Node and browser instance are connected they are able to communicate over gossipsub just fine. When the browser page is reloaded, pubsub no longer functions. I think this may be related to existing peers not being updated when they drop and reconnect. If another peer joins, pubsub functions again (which may just be the peer acting as a message router).

Steps to reproduce the error:

1. Run the bootsrap node https://github.com/libp2p/js-libp2p-examples/tree/libp2p-0.28.x/chat/nodejs/bootstrap
2. Run the final chapter browser node https://github.com/libp2p/js-libp2p-examples/tree/libp2p-0.28.x/chat/browser/08-End
3. Send messages, it should work
4. Refresh the browser page
5. Try to send a message, it should fail

[jacobheun]

The issue is fixed for js-libp2p@0.28.x. The problem was in the interfaces package, which has been patched. If you update your dependencies so you get libp2p-interfaces@0.3.1.

$ npm ls libp2p-interfaces
├─┬ libp2p@0.28.3
│ └── libp2p-interfaces@0.3.1 
├─┬ libp2p-gossipsub@0.4.5
│ └─┬ libp2p-pubsub@0.5.3
│   └── libp2p-interfaces@0.3.1  deduped

We will look into back porting this to 0.27.x to give people a little more time to upgrade given the PeerInfo breaking changes in 0.28.x.