Skip to content
This repository was archived by the owner on Jun 26, 2023. It is now read-only.
This repository was archived by the owner on Jun 26, 2023. It is now read-only.

Split the tests or interfaces out? #58

@achingbrain

Description

@achingbrain

ipfs-bitswap has a runtime dependency on this module to pull in MulticodecTopology which means it ends up installing chai and sinon and whole bunch of other testing related modules.

This module depends on libp2p-tcp to run a test, and libp2p-tcp has a dev dependency on this module to pull in the tests.

This is a bit of a code smell, maybe either the tests or the interfaces should be in a separate module to break these weird dependency loops?

Metadata

Metadata

Assignees

Labels

P3Low: Not priority right now

Type

No type

Projects

Status

🎉Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions