Skip to content

ci: change triggers to prevent dual runs on prs #1366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

clintonsteiner
Copy link
Contributor

  • runs on pushes to master or prs to master
  • will prevent action from running for the push in pr and pull request into master

* runs on pushes to master or prs to master
* will prevent action from running for the push in pr and pull request
  into master
@webknjaz
Copy link
Contributor

Personally, I'd recommend disallowing topic branches upstream via branch rulesets and forcing them into forks. This would solve said problem while still allowing branches in forks to be tested on pushes.

@jdavid
Copy link
Member

jdavid commented Aug 14, 2025

Tests and checks are fast, about 2 minutes. The slow actions (wheels, s390x tests) are only run on push to the master branch. I don't see this to be much of a problem, do I miss something?

@webknjaz
Copy link
Contributor

@jdavid this also only affects PRs from upstream, not forks. But in general, it's a good organizational decision to separate topic branches to they don't collect dust upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants