resolve string type error in GTBlob.m #650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macosx: 10.13.4, XCode Version 9.3 (9E145) reported this error compiling line 43 in GTBlob.m: Format specifies type 'ssize_t' (aka 'long') but the argument has type 'git_off_t' (aka 'long long') and suggested this fix: Replace '%zi' with '%lli' After applying the change xcode built objective-git successfully
tiennou
reviewed
Apr 8, 2018
ObjectiveGit/GTBlob.m
Outdated
| @@ -40,7 +40,7 @@ | |||
| @implementation GTBlob | |||
|
|
|||
| - (NSString *)description { | |||
| return [NSString stringWithFormat:@"<%@: %p> size: %zi, content: %@, data = %@", NSStringFromClass([self class]), self, [self size], [self content], [self data]]; | |||
| return [NSString stringWithFormat:@"<%@: %p> size: %%lli, content: %@, data = %@", NSStringFromClass([self class]), self, [self size], [self content], [self data]]; | |||
There was a problem hiding this comment.
Looks like there's an extraneous % in there.
There was a problem hiding this comment.
fixed
it was too late at night and I took a shortcut by making the change directly on github
pls squash with previous commit
pietbrauer
approved these changes
Apr 8, 2018
|
@tiennou Travis is still building on Xcode 8.3. Maybe worth an update too. 😀 |
apepper
added a commit
to apepper/gitx
that referenced
this pull request
Apr 26, 2018
Contains bugfix libgit2/objective-git#650, which reported this error compiling line 43 in GTBlob.m: Format specifies type 'ssize_t' (aka 'long') but the argument has type 'git_off_t' (aka 'long long')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macosx: 10.13.4, XCode Version 9.3 (9E145)
reported this error compiling line 43 in GTBlob.m:
Format specifies type 'ssize_t' (aka 'long') but the argument has type 'git_off_t' (aka 'long long')
and suggested this fix:
Replace '%zi' with '%lli'
After applying the change xcode built objective-git successfully