Update libgit2 to 0.26 #632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems that Travis can't checkout one of the libgit2 example repositories? |
|
Yep, they have a deliberately broken submodule file that |
tiennou
force-pushed
the
update-libgit2-0.26
branch
from
b35c555 to
1043a54
Compare
|
I've repointed the submodule to my fixed branch (which is |
|
I personally wouldn't like a "personal" fork of libgit2 for the submodule. We should wait for the issue to be fixed on their side. |
|
Looks like libgit2 got this fixed, can we get back to this one, guys? |
|
I’m all for it. |
Really, sometimes after 0.26, because of a test .gitmodules which would make Travis fail.
tiennou
force-pushed
the
update-libgit2-0.26
branch
from
1043a54 to
e605d96
Compare
|
Updated ! |
|
Sweet! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that 0.26 is a thing.
Tests have been run locally.