-
Notifications
You must be signed in to change notification settings - Fork 913
Update to libgit2 v1.2.0 #1907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to libgit2 v1.2.0 #1907
Conversation
|
Hey @bording @A-Ovchinnikov-mx, I started to look at integrating the new versions but many tests are failing 😅 Some tests like I started to look at the |
|
Ok, thanks to libgit2/git2go#777 I found the culprit for the memory corruption. A new callback EDIT: same problem with the introduction of |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1907 +/- ##
=======================================
Coverage 84.80% 84.80%
=======================================
Files 231 231
Lines 9120 9120
=======================================
Hits 7734 7734
Misses 1386 1386 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
At some point I guess we'll need to turn those padding fields into actual things, but for now I'll just go ahead and merge this. |
|
Before I push up a new preview package that uses this, I need to rip out all of the managed HTTPS implementation stuff added in #1618 and go back to using the native OpenSSL stuff. I should have some time this weekend to take a look at that. |
LibGit2Sharp.NativeBinariesto2.0.315-alpha.0.2create_commit_cb, deprecatesigning_cblibgit2#6016