NativeMethods.ResolveDll: Avoid exceptions #1741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmds
approved these changes
Nov 20, 2019
bording
approved these changes
Nov 20, 2019
|
This is now on nuget.org as 0.27.0-preview-0034. |
|
@bording Awesome, thanks! |
|
Can this be either a) implemented in the 0.26 maintenance branch and released to Nuget as |
|
Given the other work going on to try to improve the overall native binary scenario, I don't think we're at a point where we'd want to do another non-preview release yet. |
TimoWolters
added a commit
to offis/lotsen-app
that referenced
this pull request
Aug 12, 2021
The prerelease version should be able to handle missing dlls better than the official release based on libgit2/libgit2sharp#1741
TimoWolters
added a commit
to offis/lotsen-app
that referenced
this pull request
Aug 12, 2021
commit d36a0a6ede6f257b1bc2b518ba82c61888ede219 Author: Timo Wolters <[email protected]> Date: Thu Aug 12 14:14:12 2021 +0200 Update FileConfigurationStorage.cs The default configuration will be returned instead of throwing an exception. This should help make the application more resilient during startup. commit deabce5 Author: Timo Wolters <[email protected]> Date: Thu Aug 12 13:44:19 2021 +0200 Updating to LibGit2Sharp Prelease The prerelease version should be able to handle missing dlls better than the official release based on libgit2/libgit2sharp#1741 commit 98808bc Author: Timo Wolters <[email protected]> Date: Thu Aug 12 12:59:09 2021 +0200 Fixed issues with failing integration tests. Enabled integration tests in Github Actions again. Bugfix: Integration tests will no longer execute in parallel to avoid accessing shared resources. Bugfix: Fixed an issue with misleading messages during initial setup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On .NET Core 3.0, LibGit2Sharp registers a per-assembly resolver using via
NativeLibrary.SetDllImportResolver.The per-assembly resolver is the first attempt to resolve native library loads initiated by an assembly and takes precedence over other mechanisms, such as
AssemblyLoadContext.The current implementation throws an exception if the
{assemblyDirectory}/runtimesdirectory does not exist. In that case, the native load mechanism aborts, andAssemblyLoadContextnever gets a chance to locate the native library.This PR adds a
Directory.Existscheck to avoid that exception.ResolveDllwill returnIntPtr.Zero, and theAssemblyLoadContextis invoked next.